You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance.
Status: No audit logs: The added configuration changes introduce new build/test matrix entries without any accompanying audit logging for critical actions, but as these are CI workflow configs rather than runtime code, confirmation is needed whether separate logging exists in the pipeline.
Generic: Robust Error Handling and Edge Case Management
Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation
Status: No error handling: The newly added default browser version lists modify inputs but add no explicit error handling for invalid versions or fetch failures, which may be handled elsewhere in the workflow; verification is needed.
Referred Code
description: 'Build date in format YYYYMMDD. Must provide if reusing base image'required: falsetype: stringdefault: '20251101'browser-name:
description: 'Browser name to build. E.g: chrome'required: truetype: stringdefault: 'chrome'browser-versions:
description: 'List browser version to build. E.g: [130, 131]'required: truedefault: '[95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143]'push-image:
description: 'Push image after testing successfully'required: truetype: boolean
Generic: Security-First Input Validation and Data Handling
Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities
Status: Input validation: The added default version list expands external inputs but adds no explicit validation or sanity checks within the workflow inputs, which might be enforced by downstream jobs; needs confirmation.
Referred Code
description: 'Build date in format YYYYMMDD. Must provide if reusing base image'required: falsetype: stringdefault: '20251101'browser-name:
description: 'Browser name to build. E.g: firefox'required: truetype: stringdefault: 'firefox'browser-versions:
description: 'List browser version to build. E.g: [130, 131]'required: truedefault: '[98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145]'push-image:
description: 'Push image after testing successfully'required: truetype: boolean
The browser list for the new Selenium version 4.39.0 is empty; populate it with browser versions to ensure backward compatibility tests are executed for this new version.
Why: The suggestion correctly identifies that an empty browser list for Selenium 4.39.0 will cause backward compatibility tests to be skipped for this version, which is a significant oversight in the test configuration.
High
High-level
Centralize browser version management
To improve maintainability and reduce errors, consolidate the browser version lists, which are currently duplicated across multiple GitHub workflow files, into a single configuration file.
# In .github/workflows/release-chrome-versions.yml
...
browser-versions:
description: 'List browser version to build. E.g: [130, 131]'required: truedefault: '[..., 141, 142, 143]'
...
# In .github/workflows/release-edge-versions.yml
...
browser-versions:
description: 'List browser version to build. E.g: [130, 131]'required: truedefault: '[..., 141, 142, 143]'
...
After:
# In a new file, e.g., .github/config/versions.ymlchrome: '[95, ..., 143]'edge: '[114, ..., 143]'firefox: '[98, ..., 145]'chrome-for-testing: '[113, ..., 143]'# In .github/workflows/release-chrome-versions.yml# (Add a step to read the central config file)
...
browser-versions:
description: 'List browser version to build. E.g: [130, 131]'required: truedefault: ${{ steps.read_config.outputs.chrome_versions }}
...
Suggestion importance[1-10]: 6
__
Why: The suggestion correctly identifies redundant version management across multiple workflow files and proposes a valid architectural improvement for better maintainability, though it's not a critical issue.
Low
Learned best practice
Align and pin version formats
Ensure CFT_VERSION includes the package suffix for consistent pinning or drop it for both; also align CFT_VERSION and CHROME_VERSION formatting to the same pinned scheme.
Why:
Relevant best practice - Pin external tool versions consistently and avoid mixing unpinned and pinned formats; keep Chrome and Chrome for Testing versions aligned.
Low
Standardize pinning suffix usage
Match CFT_VERSION pinning with CHROME_VERSION by including the -1 package suffix so all 142 entries use the same scheme.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
This PR to update Selenium Grid 4.39.0 and backward browser versions
PR Type
Enhancement
Description
Update Selenium Grid base version from 4.38.0 to 4.39.0
Add browser version 143 to Chrome, Edge, and Firefox workflows
Add Firefox version 145 support to test matrix
Update Chrome and Edge patch versions for backward compatibility
Add Selenium 4.39.0 to test matrix configuration
Diagram Walkthrough
File Walkthrough
Makefile
Update Selenium Grid version to 4.39.0Makefile
BASE_RELEASEfrom selenium-4.38.0 to selenium-4.39.0BASE_VERSIONfrom 4.38.0 to 4.39.0VERSIONandMVN_SELENIUM_VERSIONfrom 4.38.0 to 4.39.0BASE_VERSION_NIGHTLYfrom 4.39.0-SNAPSHOT to 4.40.0-SNAPSHOTrelease-chrome-for-testing-versions.yml
Add Chrome for Testing version 143 support.github/workflows/release-chrome-for-testing-versions.yml
release-chrome-versions.yml
Add Chrome version 143 support.github/workflows/release-chrome-versions.yml
release-edge-versions.yml
Add Edge version 143 support.github/workflows/release-edge-versions.yml
release-firefox-versions.yml
Add Firefox version 145 support.github/workflows/release-firefox-versions.yml
browser-matrix.yml
Add Firefox 145 and update Chrome/Edge patch versionstests/build-backward-compatible/browser-matrix.yml
compatibility
firefox-matrix.yml
Add Firefox version 145 to test matrixtests/build-backward-compatible/firefox-matrix.yml
selenium-matrix.yml
Add Selenium 4.39.0 to test matrixtests/build-backward-compatible/selenium-matrix.yml
binding version