Fix interceptors insert tuple -> list#2088
Merged
Merged
Conversation
|
|
lawrence-c
changed the title
lawrence-c
force-pushed
the
fix-grpc-opentele
branch
from
March 24, 2025 16:50
6a2c2b3 to
eee1947
Compare
lawrence-c
marked this pull request as ready for review
March 24, 2025 16:51
Contributor
Author
|
@RobertSamoilescu as you previously edited this file in the PR, would you be able to help verify? |
RobertSamoilescu
approved these changes
Mar 28, 2025
RobertSamoilescu
left a comment
RobertSamoilescu
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thank you for your contribution.
RobertSamoilescu
pushed a commit
that referenced
this pull request
Apr 11, 2025
RobertSamoilescu
pushed a commit
that referenced
this pull request
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2028
Wasn't able to run
make testlocally, and install dependencies due to TF 2.18.0 no longer supported on intel x86, andmake testfailing out with a c++ compiler issue :/Tested separately with
and running
which successfully works