Skip to content

Included separate inference pool#2040

Merged
RobertSamoilescu merged 9 commits into
SeldonIO:masterfrom
RobertSamoilescu:feature/separate-inference-pool
Feb 4, 2025
Merged

Included separate inference pool#2040
RobertSamoilescu merged 9 commits into
SeldonIO:masterfrom
RobertSamoilescu:feature/separate-inference-pool

Conversation

@RobertSamoilescu

Copy link
Copy Markdown
Contributor

Currently MLServer can't deal well with models that are loaded on the same inference pool with other models that are heavy used. In this case there is a risk of starvation and we want to allow the user to be able to create models on separate processes (different inference pool).

MLServer does this but only if the model uses a specific custom environment tarball.

Proposed solution: Introduce inference_pool_gid to the ModelParameters class. In this way, we give the user the option to add the model to a dedicated inference pool group. Note that this allows to add either a single model or multiple models to the same group. I also included the autogenerate_inference_pool_gid boolean flag. When set to True and no inference_pool_gid is provided, a gid is generated using uuid4. This will add the model to a dedicated group - this way the user does not have to specify the gid themself.

@sakoush sakoush left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Docs should follow this PR to describe the new fields.

Comment thread mlserver/parallel/registry.py Outdated
Comment thread mlserver/parallel/registry.py Outdated
Comment thread mlserver/settings.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants