Fixes for all-runtimes#1794
Merged
RobertSamoilescu merged 9 commits intoJun 7, 2024
Merged
Conversation
sakoush
approved these changes
Jun 6, 2024
sakoush
left a comment
sakoush
left a comment
Contributor
There was a problem hiding this comment.
lgtm. please clarify in the code why these changes are added.
| matches = glob.glob(pattern) | ||
|
|
||
| for match in matches: | ||
| if match.endswith("3.1"): |
Contributor
There was a problem hiding this comment.
why is this required? add a note in the code.
| return uvicorn.Config(self._app, **kwargs) | ||
|
|
||
| async def stop(self, sig: Optional[int] = None): | ||
| if sig is None: |
Contributor
There was a problem hiding this comment.
why is this required? add a note in the code
RobertSamoilescu
force-pushed
the
fix/all-runtimes-fixes
branch
from
June 7, 2024 09:56
f8ea440 to
0283232
Compare
RobertSamoilescu
force-pushed
the
fix/all-runtimes-fixes
branch
from
June 7, 2024 09:58
0283232 to
7b85fd6
Compare
sakoush
reviewed
Jun 7, 2024
|
|
||
| # Ensure that having all the runtimes installed together works | ||
| all-runtimes: | ||
| if: github.event_name == 'push' |
Contributor
There was a problem hiding this comment.
assuming this is for testing, revert back before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes some minor fixes for the
all-runtimestests.