Skip to content

basic contributing guide on contributing and opening a PR#1773

Merged
sakoush merged 1 commit into
SeldonIO:masterfrom
bohemia420:doc_CONTRIBUTING
May 22, 2024
Merged

basic contributing guide on contributing and opening a PR#1773
sakoush merged 1 commit into
SeldonIO:masterfrom
bohemia420:doc_CONTRIBUTING

Conversation

@bohemia420

Copy link
Copy Markdown
Contributor

Pull Request

Description

Basic improvements to CONTRIBUTING.md guide, besides a PR template for raising better/detailed PRs

Changes Made

  • inside /docs/ a pull request template folder, with a default PR template like this has been created.
  • inside CONTRIBUTING.md doc, some best-effort ways to open/raise a PR, and install/develop along the main repo's master is suggested.

Related Issues

Screenshots (if applicable)

Checklist

  • Code follows the project's style guidelines
  • All tests related to the changes pass successfully
  • Documentation is updated (if necessary)
  • Code is reviewed by at least one other team member
  • Any breaking changes are communicated and documented

Additional Notes

@sakoush

sakoush commented May 20, 2024

Copy link
Copy Markdown
Contributor

@bohemia420 many thanks for your contribution!

@sakoush sakoush left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I just left a minor note on "installation" to reference perhaps an existing page?

Comment thread CONTRIBUTING.md
@sakoush
sakoush merged commit aad4a5a into SeldonIO:master May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants