Skip to content

build: Bump versions for Read the Docs#1761

Merged
jesse-c merged 4 commits into
SeldonIO:masterfrom
jesse-c:bump-rtd-versions
May 16, 2024
Merged

build: Bump versions for Read the Docs#1761
jesse-c merged 4 commits into
SeldonIO:masterfrom
jesse-c:bump-rtd-versions

Conversation

@jesse-c

@jesse-c jesse-c commented May 15, 2024

Copy link
Copy Markdown
Contributor

We don't support Python 3.8 anymore.

Poetry 1.8.1 matches what's currently in our Poetry lockfile.

Building the docs is currently failing [1], and this ideally will fix that.

[1] From readthedocs.org:

poetry install -vvv --without dev --with docs --with all-runtimes --with all-runtimes-dev
Loading configuration file /home/docs/.config/pypoetry/config.toml
The currently activated Python version 3.8.18 is not supported by the project (>=3.9,<3.12).
Trying to find and use a compatible version.
Trying python3
Trying python3.9

We don't support Python `3.8` anymore.

Poetry `1.8.1` matches what's currently in our Poetry lockfile.

Building the docs is currently failing [1], and this ideally will fix that.

[1] From readthedocs.org:
```
poetry install -vvv --without dev --with docs --with all-runtimes --with all-runtimes-dev
Loading configuration file /home/docs/.config/pypoetry/config.toml
The currently activated Python version 3.8.18 is not supported by the project (>=3.9,<3.12).
Trying to find and use a compatible version.
Trying python3
Trying python3.9
```

@sakoush sakoush left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for fixing it.

jesse-c added 3 commits May 16, 2024 11:20
There's still been some failures [2], so I've updated it to follow
their recommendation [1].

[1] https://docs.readthedocs.io/en/stable/build-customization.html#install-dependencies-with-poetry
[2]
```
Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/mlserver/envs/1761/lib/python3.10/site-packages/sphinx/config.py", line 509, in eval_config_file
    exec(code, namespace)  # NoQA: S102
  File "/home/docs/checkouts/readthedocs.org/user_builds/mlserver/checkouts/1761/docs/conf.py", line 19, in <module>
    import sphinx_material
ModuleNotFoundError: No module named 'sphinx_material'
```
@jesse-c

jesse-c commented May 16, 2024

Copy link
Copy Markdown
Contributor Author

@sakoush: No worries! Thanks for the review. I added the final changes [1] to get it building [2].

[1] a035768
[2]
24-05-16_11-38-55

@jesse-c jesse-c self-assigned this May 16, 2024
@jesse-c
jesse-c merged commit 1aab084 into SeldonIO:master May 16, 2024
@jesse-c
jesse-c deleted the bump-rtd-versions branch May 16, 2024 10:57
jesse-c pushed a commit that referenced this pull request May 16, 2024
* build: Bump versions for Read the Docs

We don't support Python `3.8` anymore.

Poetry `1.8.1` matches what's currently in our Poetry lockfile.

Building the docs is currently failing [1], and this ideally will fix that.

[1] From readthedocs.org:
```
poetry install -vvv --without dev --with docs --with all-runtimes --with all-runtimes-dev
Loading configuration file /home/docs/.config/pypoetry/config.toml
The currently activated Python version 3.8.18 is not supported by the project (>=3.9,<3.12).
Trying to find and use a compatible version.
Trying python3
Trying python3.9
```

* docs: Bump copyright year

* build: Use Python env for server

* build: Use recommended Read the Docs setup

There's still been some failures [2], so I've updated it to follow
their recommendation [1].

[1] https://docs.readthedocs.io/en/stable/build-customization.html#install-dependencies-with-poetry
[2]
```
Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/mlserver/envs/1761/lib/python3.10/site-packages/sphinx/config.py", line 509, in eval_config_file
    exec(code, namespace)  # NoQA: S102
  File "/home/docs/checkouts/readthedocs.org/user_builds/mlserver/checkouts/1761/docs/conf.py", line 19, in <module>
    import sphinx_material
ModuleNotFoundError: No module named 'sphinx_material'
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants