Skip to content

refactor(pydantic): Remaining migrations for deprecated functions#1757

Merged
jesse-c merged 1 commit into
SeldonIO:masterfrom
jesse-c:post-pydantic-v2-deprecated-fns
May 13, 2024
Merged

refactor(pydantic): Remaining migrations for deprecated functions#1757
jesse-c merged 1 commit into
SeldonIO:masterfrom
jesse-c:post-pydantic-v2-deprecated-fns

Conversation

@jesse-c

@jesse-c jesse-c commented May 13, 2024

Copy link
Copy Markdown
Contributor

These were missed in #1748.

@jesse-c jesse-c self-assigned this May 13, 2024
@jesse-c
jesse-c requested a review from mauicv May 13, 2024 11:36

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explain: The whitespace changes are for trailing spaces, which shouldn't be there.

@mauicv mauicv left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jesse-c

jesse-c commented May 13, 2024

Copy link
Copy Markdown
Contributor Author

Tests are passing again (so far just tested locally) after #1758.

@jesse-c
jesse-c merged commit a2c0d64 into SeldonIO:master May 13, 2024
@jesse-c
jesse-c deleted the post-pydantic-v2-deprecated-fns branch May 13, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants