Skip to content

build: Add granularity in types generation#1749

Merged
jesse-c merged 2 commits into
SeldonIO:masterfrom
jesse-c:separate-types-generation-targets
May 8, 2024
Merged

build: Add granularity in types generation#1749
jesse-c merged 2 commits into
SeldonIO:masterfrom
jesse-c:separate-types-generation-targets

Conversation

@jesse-c

@jesse-c jesse-c commented May 8, 2024

Copy link
Copy Markdown
Contributor

This makes it easier to know which types generation is failing. It's a follow-on from #1729.

jesse-c added 2 commits May 8, 2024 14:37
These 2 were missing this supported version. It would've caught me
using `TypeAlias` on 3.9 earlier.
This makes it easier to know which types generation is failing. It's a
follow-on from #1729.
@jesse-c jesse-c self-assigned this May 8, 2024
@jesse-c
jesse-c marked this pull request as ready for review May 8, 2024 13:48

@mauicv mauicv left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesse-c
jesse-c merged commit 410cf6f into SeldonIO:master May 8, 2024
@jesse-c
jesse-c deleted the separate-types-generation-targets branch May 8, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants