Fix kafka json byte encoding to match rest server#1622
Conversation
|
@DerTiedemann many thanks for you draft PR. This looks fine in general. We are happy to potentially accept your contribution once it is ready and reviewed. |
refactored common logic into new codec class
81d61ee to
a7172a9
Compare
|
@sakoush ready for review! |
sakoush
left a comment
sakoush
left a comment
There was a problem hiding this comment.
@DerTiedemann many thanks for your contribution, this looks great. I left minor comments but should be good to go once they are addressed.
|
@DerTiedemann any feedback on review comments? |
|
I haven't been able to work on this recently. In general they are fine and I agree with the requested changes. |
|
|
The function encode_to_json_bytes is the same as _render
sakoush
left a comment
sakoush
left a comment
There was a problem hiding this comment.
Lgtm. Many thanks for your contribution @DerTiedemann
|
@DerTiedemann I have re-triggered CI actions. Looks like there are some issues, e.g linting. For now please discard macos tests as they are currently broken anyway. |
|
@DerTiedemann many thanks for the contribution. I rebased, fixed minor linting issues and merged it. |
3 participants
fixes #1621