Skip to content

build: Bump version and improve release doc#1602

Merged
jesse-c merged 3 commits into
SeldonIO:masterfrom
jesse-c:build-improve-version-bump
Mar 1, 2024
Merged

build: Bump version and improve release doc#1602
jesse-c merged 3 commits into
SeldonIO:masterfrom
jesse-c:build-improve-version-bump

Conversation

@jesse-c

@jesse-c jesse-c commented Mar 1, 2024

Copy link
Copy Markdown
Contributor

Bumps the version to match the latest release and improves the release doc, to mention this.

FIXES INFRA-838

@jesse-c jesse-c self-assigned this Mar 1, 2024
@jesse-c
jesse-c requested a review from sakoush March 1, 2024 10:16

@sakoush sakoush left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the pattern is to upgrade the version to the next dev version, so 1.5.0.dev1 in the master branch. For the official releases (on the release branches), the CI will tag the version on them properly.

@jesse-c

jesse-c commented Mar 1, 2024

Copy link
Copy Markdown
Contributor Author

Ah, that makes sense. Since it may be 1.4.1.dev too, is it best to leave it as is? Or just pick one and adjust as we need? (I'll do the latter)

@jesse-c
jesse-c requested a review from sakoush March 1, 2024 10:43
@jesse-c

jesse-c commented Mar 1, 2024

Copy link
Copy Markdown
Contributor Author

Changed to 1.5.0.dev1. Thank you!

@sakoush sakoush left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jesse-c
jesse-c merged commit 7ac4351 into SeldonIO:master Mar 1, 2024
@jesse-c
jesse-c deleted the build-improve-version-bump branch March 1, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants