Skip to content

docs: List supported Python versions #1591

Merged
jesse-c merged 2 commits into
SeldonIO:masterfrom
jesse-c:supported-py-versions
Mar 4, 2024
Merged

docs: List supported Python versions #1591
jesse-c merged 2 commits into
SeldonIO:masterfrom
jesse-c:supported-py-versions

Conversation

@jesse-c

@jesse-c jesse-c commented Feb 28, 2024

Copy link
Copy Markdown
Contributor

Python 3.8 is due to reach its scheduled upstream end-of-life in October 2024.

In preparation for this, we're marking support for this version as deprecated. It's still available, but will be removed in a future version.

@jesse-c jesse-c added the documentation Improvements or additions to documentation label Feb 28, 2024
@jesse-c
jesse-c requested a review from sakoush February 28, 2024 14:25
@jesse-c jesse-c self-assigned this Feb 28, 2024
sakoush
sakoush reviewed Feb 29, 2024
View reviewed changes

@sakoush sakoush left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably establish whether mlserver supports py11 and py12

@jesse-c

jesse-c commented Feb 29, 2024

Copy link
Copy Markdown
Contributor Author

@sakoush: I was thinking about that. I did some brief testing, and had some dependency installation failures on Python 3.11.8. Happy to update it to say that it's "untested" or something like that.

wdyt?

@sakoush

sakoush commented Feb 29, 2024

Copy link
Copy Markdown
Contributor

@sakoush: I was thinking about that. I did some brief testing, and had some dependency installation failures on Python 3.11.8. Happy to update it to say that it's "untested" or something like that.

wdyt?

yes we need to reflect status and perhaps also add an issue to investigate why mlserver doesnt work on py3.11.

@jesse-c

jesse-c commented Feb 29, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I've added mentions for 3.11 and 3.12 in this change.

@RafalSkolasinski

RafalSkolasinski commented Mar 1, 2024

Copy link
Copy Markdown
Contributor

As far as I understand #1603 removed support for Python 3.8.
Because of

MLServer/pyproject.toml

Line 46 in 775fa4f

python = ">=3.9,<3.12"

it will not be able to use it with Python 3.8 so it is not deprecated but removed

@jesse-c

jesse-c commented Mar 1, 2024

Copy link
Copy Markdown
Contributor Author

@RafalSkolasinski: This PR was opened before that, so I'll update this now.

@jesse-c

jesse-c commented Mar 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@RafalSkolasinski: Done! Thank you for the reminder. 🙏🏻

Update: It's not showing up yet in the PR view here, but you can see it on my branch. Hopefully it'll show up soon.

@jesse-c

jesse-c commented Mar 1, 2024

Copy link
Copy Markdown
Contributor Author

@RafalSkolasinski: It's showing up now!

@jesse-c
jesse-c merged commit 62e1d4e into SeldonIO:master Mar 4, 2024
@jesse-c
jesse-c deleted the supported-py-versions branch March 4, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RafalSkolasinski RafalSkolasinski Awaiting requested review from RafalSkolasinski
1 more reviewer
@sakoush sakoush sakoush approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jesse-c jesse-c

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jesse-c @sakoush @RafalSkolasinski