Publish is_drift metric to Prom#1263
Merged
Merged
Conversation
adriangonz
changed the title
ascillitoe
reviewed
Jun 30, 2023
ascillitoe
left a comment
ascillitoe
left a comment
There was a problem hiding this comment.
Two initial questions before final review.
| return | ||
|
|
||
| data = current_pred["data"] | ||
| if "is_drift" in data: |
There was a problem hiding this comment.
Question for @adriangonz and @joshsgoldstein. What is the motivation for this PR?
Asking as wondering if we are definitely only concerned about is_drift here? Often p_val and distance are of equal (or greater) interest. As is threshold, and distance_threshold (dependent on detector).
Contributor
Author
There was a problem hiding this comment.
@ascillitoe we are enabling scv2 alerting in deploy
Contributor
There was a problem hiding this comment.
Initially we will just expose is_drift - as that's good enough to set up alerting. I agree that exposing the other metrics will eventually become important though, but that's probably outside the scope of this PR.
ascillitoe
approved these changes
Jul 3, 2023
adriangonz
pushed a commit
that referenced
this pull request
Jul 4, 2023
Co-authored-by: Josh <[email protected]> Co-authored-by: Adrian Gonzalez-Martin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added drift metrics to be scraped by prometheus