Repository navigation
Stop JsonFormatter from encoding INF and NaN as 0 - #2078
Merged
Merged
Conversation
Owner
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JsonFormatterlogsINF,-INFandNANas0:JSON has no representation for these values.
json_encode()fails on them, and becauseUtils::DEFAULT_JSON_FLAGSincludesJSON_PARTIAL_OUTPUT_ON_ERROR, each one is replaced with0. That reads like a real measurement, so the log ends up misleading rather than visibly broken.NormalizerFormatter::normalize()already maps these to the strings'INF','-INF'and'NaN'(from #523), andLineFormattergets that for free.JsonFormatteroverridesnormalize()and returns scalars untouched, so it missed out. This PR hands non-finite floats to the parent, soJsonFormattergives the same output as the other formatters. All other scalars are still returned as they are.I added a JsonFormatter test covering
INF,-INF,NAN, a nestedINF, and a normal float. It fails onmainwith0 is identical to 'INF'. The full PHPUnit suite and PHPStan pass.