Conversation
committing to compile on gcc to see if it's clearer
not sure why as long as one argument has a size should use that. but w/e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generic Combo Classes Refactor
GenericComboclasses (GenericCombo,GenericComboWithFilter,GenericComboWithMultiFilter, andGenericComboWithCustomFilter) to usestd::spanfor passing ranges (values, strings, tooltips, and filters) instead of lambdas. RemovedValueLambdaT(and potentially other lambda types) as the classes now directly accept value ranges viastd::span, simplifying the interface, reducing runtime overhead, and improving clarity with precomputed data.requiresclause toGenericComboWithMultiFilter(and potentially other relevant classes) to ensure the filter type supports anupdatemethod with a vector of values from the provided range, enhancing compile-time validation.Filter System Refactor
ff_8::filter_oldwithff_8::filterforCompactandFlatteninSelections.hpp, modernizing the filter implementation.tile.cppfrommap->filter().deswizzle.enabled()tomap->filter().enabled<ff_8::FilterTag::Deswizzle>()(and similar forFullFileNameandSwizzle) for type-safe, templated access.batch.cpp, updated filter updates to use templatedupdatemethod with chained.enable()calls (e.g.,filters.update<ff_8::FilterTag::Deswizzle>(...)), improving consistency and conciseness.filter.hpp(350 additions, 240 deletions) to support the newfilterclass andstd::span-based API.Benefits
requiresclause ensure compile-time validation.std::spanreduces overhead by avoiding lambda calls and data copies.std::spansimplifies the API across allGenericComboclasses.std::spanandrequires.