Skip to content

Add ETag support for file library#1325

Merged
jbrichau merged 3 commits intoSeasideSt:masterfrom
marschall:filelibrary-etag
Sep 1, 2023
Merged

Add ETag support for file library#1325
jbrichau merged 3 commits intoSeasideSt:masterfrom
marschall:filelibrary-etag

Conversation

@marschall
Copy link
Copy Markdown
Contributor

@marschall marschall commented Aug 20, 2022

Fixes #1324

@marschall
Copy link
Copy Markdown
Contributor Author

marschall commented Aug 20, 2022

Requires SeasideSt/Grease#140

@marschall marschall added the CampSmalltalk 2022 Issues worked on at CampSmalltalk 2022 in Novi Sad label Aug 21, 2022
@jbrichau
Copy link
Copy Markdown
Member

jbrichau commented Aug 26, 2022

The annoying situation here is that GemStone uses https://github.com/GsDevKit/Grease instead of the SeasideSt/Grease... which is why the tests are still failing (at least).
Will do the PR to GsDevKit to ping Dale.

@astares
Copy link
Copy Markdown
Contributor

astares commented Jun 30, 2023

Any update on this?

@jbrichau
Copy link
Copy Markdown
Member

jbrichau commented Jul 1, 2023

Any update on this?

I will take a look why the tests are failing for GemStone

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 1, 2023 •
edited
Loading

Codecov Report

Patch coverage: 89.58% and project coverage change: +0.01% 🎉

Comparison is base (c152487) 54.44% compared to head (95d0f2e) 54.46%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1325      +/-   ##
==========================================
+ Coverage   54.44%   54.46%   +0.01%     
==========================================
  Files        8833     8837       +4     
  Lines       71719    71759      +40     
==========================================
+ Hits        39045    39080      +35     
- Misses      32674    32679       +5
Files Changed Coverage Δ
...e.package/WAResponse.class/instance/notModified.st 0.00% <0.00%> (ø)
...bstractFileLibrary.class/instance/entityTagFor..st 100.00% <100.00%> (ø)
...re.package/WAFileLibrary.class/instance/handle..st 100.00% <100.00%> (ø)
...ge/WAFileMetadataLibrary.class/instance/handle..st 100.00% <100.00%> (ø)
...re.package/WARequest.class/instance/ifNoneMatch.st 100.00% <100.00%> (ø)
...re.package/WAResponse.class/instance/entityTag..st 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbrichau jbrichau merged commit 9d9ab4d into SeasideSt:master Sep 1, 2023
@jbrichau jbrichau mentioned this pull request Jan 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbrichau jbrichau jbrichau approved these changes

Assignees

No one assigned

Labels

CampSmalltalk 2022 Issues worked on at CampSmalltalk 2022 in Novi Sad

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add ETag support for file library

3 participants

@marschall @jbrichau @astares