Skip to content

Support Pharo native Deprecation#180

Merged
jbrichau merged 4 commits intoSeasideSt:masterfrom
marschall:add-Depreaction
Jul 17, 2024
Merged

Support Pharo native Deprecation#180
jbrichau merged 4 commits intoSeasideSt:masterfrom
marschall:add-Depreaction

Conversation

@marschall
Copy link
Copy Markdown
Contributor

@marschall marschall commented Jul 12, 2024 •
edited
Loading

Implement #deprecationExceptionSet for Pharo and add Deprecation.

Currently #deprecationExceptionSet is empty for Pharo resulting in a nasty stack trace if somebody sends a message that Pharo deprecated, see #179.

DeprecationMissing

Unfortunately this doesn't actually make Deprecation work with the Seaside tools as Deprecation >> #messageText results in a MNU. This looks like a Pharo bug to me, I filed pharo-project/pharo#16897.

UndefinedObject(Object)>>doesNotUnderstand: #homeMethod
Deprecation>>sendingMethodName
[ :str |
		self shouldTransform ifTrue: [
			str nextPutAll:  'Automatic deprecation code rewrite: '].
		str
			nextPutAll: 'The method ';
			nextPutAll: self deprecatedMethodName;
			nextPutAll: ' called from ';
			nextPutAll: self sendingMethodName;
			nextPutAll: ' has been deprecated. ';
		 	nextPutAll: explanationString] in Deprecation>>messageText in Block: [ :str |...
String class(SequenceableCollection class)>>new:streamContents:
String class(SequenceableCollection class)>>streamContents:
Deprecation>>messageText
[ :each | 
		(each messageText = aNotification messageText)
			and: [ each details = aNotification details ] ] in WADeprecatedToolFilter>>deprecated: in Block: [ :each | ...
OrderedCollection>>reject:
WADeprecatedToolFilter>>deprecated:
[ :notification | self deprecated: notification ] in WADeprecatedToolFilter>>handleFiltered: in Block: [ :notification | self deprecated: notification ]

@marschall
Support Pharo native Deprecation
3bf54ec 
Implement for Pharo and add Deprecation.
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.15%. Comparing base (737de76) to head (6ca509f).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
+ Coverage   85.12%   85.15%   +0.02%     
==========================================
  Files        2054     2058       +4     
  Lines       14121    14149      +28     
==========================================
+ Hits        12020    12048      +28     
  Misses       2101     2101

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marschall marschall marked this pull request as draft July 13, 2024 13:03
@marschall marschall marked this pull request as ready for review July 14, 2024 09:33
@marschall
Copy link
Copy Markdown
Contributor Author

marschall commented Jul 14, 2024

No idea why GemStone/S is failing

Unhandled Error in script: /home/runner/.smalltalkCI/_builds/repos/GsDevKit_stones/bin/loadTode.stone
---------------------
a MetacelloPackageSpecResolutionError occurred (error 2710), Could not resolve: ConfigurationOfMetacello [ConfigurationOfMetacello] in /home/runner/.smalltalkCI/_builds/stones/smalltalkci/package-cache http://seaside.gemtalksystems.com/ss/metacello
---------------------
1 [] in SuperDoitExecution >> doit @69 line 42  [GsNMethod 111145473]
Could not resolve: ConfigurationOfMetacello [ConfigurationOfMetacello] in /home/runner/.smalltalkCI/_builds/stones/smalltalkci/package-cache http://seaside.gemtalksystems.com/ss/metacello

Unhandled Error in script: /home/runner/.smalltalkCI/_builds/repos/GsDevKit_stones/bin/loadTode.stone
---------------------
UserDefinedError: can't find EOCD position
---------------------
1 [] in SuperDoitExecution >> doit @41 line 32  [GsNMethod 108265985]
UserDefinedError: can't find EOCD position
2 UserDefinedError (AbstractException) >> _executeHandler: @7 line 11  [GsNMethod 3907329]
3 UserDefinedError (AbstractException) >> _signalWith: @1 line 2  [GsNMethod 3915009]
4 UserDefinedError (AbstractException) >> signal @2 line 47  [GsNMethod 3902977]
5 ZipArchive (Object) >> error: @6 line 7  [GsNMethod 6181633]
6 ZipArchive >> readFrom: @14 line 10  [GsNMethod 29782273]
7 MCMczReader >> zip @5 line 4  [GsNMethod 40344321]

@jbrichau
Copy link
Copy Markdown
Member

jbrichau commented Jul 14, 2024

Try running it again. This error means a problem with the squeaksource server on http://seaside.gemtalksystems.com/ss/

Something I promised Dale to take a look at and convert to a plain webserver.... but it became less urgent as the stability had improved. So, just run that build again. It will probably work.

@jbrichau
Copy link
Copy Markdown
Member

jbrichau commented Jul 14, 2024

I re-ran the failed builds and now they pass.

@jbrichau jbrichau merged commit 49a3d6e into SeasideSt:master Jul 17, 2024
@marschall
Copy link
Copy Markdown
Contributor Author

marschall commented Jul 20, 2024

Thx, Pharo bug is fixed as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbrichau jbrichau jbrichau approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marschall @jbrichau