Merged
Conversation
* Add `RelationBuilder` trait * Use seaography flag on generation * Use DeriveRelatedEntity macro * Slim down parsing * Slim down code generation
4 tasks
tyt2y3
reviewed
Apr 18, 2023
billy1624
reviewed
Apr 20, 2023
Member
billy1624
left a comment
billy1624
left a comment
There was a problem hiding this comment.
Amazing work!! The API looks really good!
Can we make register_entity!() take an array of entity module paths?
It returns the seaography `Builder`
billy1624
reviewed
May 17, 2023
Member
billy1624
left a comment
billy1624
left a comment
There was a problem hiding this comment.
Hey @karatakis, I added a commit here f23b1af
To support the following commit in SeaQL/sea-orm#1599
- A demo for how to construct the
async-graphqlquery root for entity with/withoutRelatedEntityc84294e
Member
|
I think we should keep |
Member
|
Okay, keep the name of commonly used marco short :P |
billy1624
reviewed
May 18, 2023
Member
billy1624
left a comment
billy1624
left a comment
There was a problem hiding this comment.
Hey @karatakis, I just updated all three examples, please check :)
Member
|
Looks very good |
billy1624
reviewed
May 19, 2023
Member
billy1624
left a comment
billy1624
left a comment
There was a problem hiding this comment.
Hey @tyt2y3 @karatakis, please review
tyt2y3
approved these changes
May 20, 2023
tyt2y3
approved these changes
May 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Info
query_root.rs#130New Features
query_root.rsBreaking Changes
seaographywhen generating entities usingsea-orm-cliChanges
query_root.rsfile is generated