Conversation
Member
Author
|
there is no way to read this code diff other than going commit by commit. every commit is compilable. but summary of changes:
|
hopefully this can get optimized
Expurple
approved these changes
Jul 14, 2025
Co-authored-by: Dmitrii Aleksandrov <[email protected]>
Co-authored-by: Dmitrii Aleksandrov <[email protected]>
Member
Author
|
special thanks to @Huliiiiii for bringing forward the proposal! |
SindriFr
pushed a commit
to SindriFr/sea-query
that referenced
this pull request
Jul 21, 2025
* 1. change unquoted() signature * 2. change quoted() signature * 3. introduce unquoted_static * 4. remove prepare from iden * 5. remove type-sensitive comparison * remove quote from quoted * 6. revamp SeaRc and DynIden * rename to prepare_iden * tweaks * Impl IntoIden for String * improve tests * clippy * const fn is_static_iden hopefully this can get optimized * Apply suggestions from code review Co-authored-by: Dmitrii Aleksandrov <[email protected]> * Update src/types.rs Co-authored-by: Dmitrii Aleksandrov <[email protected]> * dep * fix build --------- Co-authored-by: Dmitrii Aleksandrov <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed,
Arc,vtabletricks are removed.The biggest behaviour change is late binding to early binding. previously the Iden is only rendered when the AST is being serialized, now that we pre-render it as we store that into the AST.
For majority of usecases in SeaORM though, since they're
'static stranyway, there should be no difference.It is still possible to have
struct MyIden(String)with some dynamic behaviour.@Huliiiiii