Skip to content

Remove redundant Expr::expr from docs and internal code#873

Merged
tyt2y3 merged 1 commit intoSeaQL:masterfrom
Expurple:dont-use-expr-expr
Apr 12, 2025
Merged

Remove redundant Expr::expr from docs and internal code#873
tyt2y3 merged 1 commit intoSeaQL:masterfrom
Expurple:dont-use-expr-expr

Conversation

@Expurple
Copy link
Copy Markdown
Member

@Expurple Expurple commented Apr 1, 2025

PR Info

  • Closes: none
  • Dependencies: none
  • Dependents: none

New Features

Bug Fixes

Breaking Changes

Changes

(probably not changelog-worthy)

  • Removed redundant Expr::expr calls from docs and internal code.
  • Updated the wording in the relevant docs.

Explained in more defail there:

Since `sea_query` 0.32.0 (`sea_orm` 1.1.1), **this is not necessary** in most cases!

Some SQL operations used to be defined only as inherent methods on [`Expr`].
Thus, to use them, you needed to manually convert from other types to [`Expr`].
But now these operations are also defined as [`ExprTrait`] methods
that can be called directly on any expression type,

The diff speaks for itself. Let's move the ecosystem towards the cleaner style!

@Expurple Expurple mentioned this pull request Apr 2, 2025
Merged
tyt2y3
tyt2y3 approved these changes Apr 12, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! it definitely looks nicer

@tyt2y3 tyt2y3 merged commit 3806005 into SeaQL:master Apr 12, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tyt2y3 tyt2y3 tyt2y3 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Expurple @tyt2y3