Skip to content

feat: add Expr::column#852

Merged
tyt2y3 merged 1 commit intoSeaQL:masterfrom
tisonkun:expr-column
Feb 2, 2025
Merged

feat: add Expr::column#852
tyt2y3 merged 1 commit intoSeaQL:masterfrom
tisonkun:expr-column

Conversation

@tisonkun
Copy link
Copy Markdown
Contributor

@tisonkun tisonkun commented Dec 31, 2024

The same as Expr::value to Expr::val.

I'm using this and now work it around with Expr::col(...).into().

ikrivosheev
ikrivosheev approved these changes Jan 29, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ikrivosheev ikrivosheev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisonkun
Copy link
Copy Markdown
Contributor Author

tisonkun commented Jan 31, 2025

@ikrivosheev Thanks for your review!

May I ask what the normal process for merging a patch and cutting a new release? I'd expect a new release with this patch so that I can switch my project to depend on the new version for the changeset.

@ikrivosheev
Copy link
Copy Markdown
Contributor

ikrivosheev commented Jan 31, 2025

@ikrivosheev Thanks for your review!

May I ask what the normal process for merging a patch and cutting a new release? I'd expect a new release with this patch so that I can switch my project to depend on the new version for the changeset.

Well, I'll review a chunk of PR and then merge it and write chabgelog.

After I can prepare a release.

@tyt2y3
Copy link
Copy Markdown
Member

tyt2y3 commented Feb 2, 2025

Thanks @ikrivosheev ! Let's merge this

@tyt2y3 tyt2y3 merged commit 12639c2 into SeaQL:master Feb 2, 2025
@tisonkun tisonkun deleted the expr-column branch February 3, 2025 01:29
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 18, 2025

🎉 Released In 0.32.2 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ikrivosheev ikrivosheev ikrivosheev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tisonkun @ikrivosheev @tyt2y3