Skip to content

Support INCLUDE clause for PostgreSQL BTree index#826

Merged
tyt2y3 merged 1 commit intoSeaQL:masterfrom
yuly3:issue-775
Feb 16, 2025
Merged

Support INCLUDE clause for PostgreSQL BTree index#826
tyt2y3 merged 1 commit intoSeaQL:masterfrom
yuly3:issue-775

Conversation

@yuly3
Copy link
Copy Markdown
Contributor

@yuly3 yuly3 commented Oct 5, 2024

PR Info

New Features

  • Support INCLUDE clause for PostgreSQL BTree index

Copy link
Copy Markdown
Contributor

@ikrivosheev ikrivosheev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Comment on lines +83 to +86

#[doc(hidden)]
// Write INCLUDE clause for index. This function is only available in PostgreSQL.
fn prepare_include_columns(&self, _columns: &[SeaRc<dyn Iden>], _sql: &mut dyn SqlWriter) {}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's for one backend only, I would remove it from the common interface

@tyt2y3
Copy link
Copy Markdown
Member

tyt2y3 commented Feb 16, 2025

I will make a tweak

@tyt2y3 tyt2y3 merged commit 8c40438 into SeaQL:master Feb 16, 2025
@tyt2y3
Copy link
Copy Markdown
Member

tyt2y3 commented Feb 16, 2025

The commit message, oh haha

@github-actions
Copy link
Copy Markdown

🎉 Released In 0.32.2 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

@yuly3 yuly3 deleted the issue-775 branch February 18, 2025 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for Postgres BTree index INCLUDE (<col>, ...)

3 participants