Skip to content

Add possibility to configure the Table enum variant Iden implementation with enum_def macro#759

Merged
tyt2y3 merged 2 commits intoSeaQL:masterfrom
baptiste-le-m:table_iden_option_on_enum_def
Apr 14, 2024
Merged

Add possibility to configure the Table enum variant Iden implementation with enum_def macro#759
tyt2y3 merged 2 commits intoSeaQL:masterfrom
baptiste-le-m:table_iden_option_on_enum_def

Conversation

@baptiste-le-m
Copy link
Copy Markdown
Contributor

@baptiste-le-m baptiste-le-m commented Mar 9, 2024

Hello !

Add possibility to configure the Table enum variant Iden implementation with enum_def macro

Do you think it would possible to merge the PR ?
Does the feature fit in what you are trying to do ?

tyt2y3
tyt2y3 reviewed Mar 10, 2024
View reviewed changes
@baptiste-le-m baptiste-le-m force-pushed the table_iden_option_on_enum_def branch from b96909e to 7e6b85f Compare March 10, 2024 19:30
@tyt2y3 tyt2y3 mentioned this pull request Apr 14, 2024
Closed
@tyt2y3 tyt2y3 merged commit dc27eb0 into SeaQL:master Apr 14, 2024
@tyt2y3
Copy link
Copy Markdown
Member

tyt2y3 commented Apr 14, 2024

I changed table_iden to table_name

@baptiste-le-m baptiste-le-m deleted the table_iden_option_on_enum_def branch April 14, 2024 20:25
@tyt2y3
Copy link
Copy Markdown
Member

tyt2y3 commented Apr 14, 2024

Released https://crates.io/crates/sea-query-attr/versions

@tyt2y3
Copy link
Copy Markdown
Member

tyt2y3 commented Apr 14, 2024

As mentioned in another comment, I would like to deprecate sea-query-attr and move the macro into sea-query-derive. However, we'll have to migrate to syn2 and probably rename a few things. Would you like to do that?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2024

🎉 Released In 0.31.0-rc.5 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

@tyt2y3 tyt2y3 mentioned this pull request Apr 17, 2024
Merged
6 tasks
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 9, 2024

🎉 Released In 0.31.0 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tyt2y3 tyt2y3 tyt2y3 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@baptiste-le-m @tyt2y3