fix the CI: update bigdecimal and fix warnings#718
Closed
kyoto7250 wants to merge 2 commits intoSeaQL:masterfrom
Closed
fix the CI: update bigdecimal and fix warnings#718kyoto7250 wants to merge 2 commits intoSeaQL:masterfrom
kyoto7250 wants to merge 2 commits intoSeaQL:masterfrom
Conversation
kyoto7250
changed the title
kyoto7250
commented
Nov 2, 2023
| bytes.iter().fold(String::new(), |mut output, b| { | ||
| let _ = write!(output, "{b:02X}"); | ||
| output | ||
| }) |
Contributor
Author
There was a problem hiding this comment.
Member
|
Thank you for the PR. I cherry-picked these already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Info
This PR has two fixes for CI.
update bigdecimal 0.4.1 -> 0.4.2
It seems that CI is failing due to
bigdecimalbeing updated.This PR updates the version of
bigdecimal.fix warnings
CI is failing due to linter's warnings.
This PR fixes the warnings.
links
bigdecimal
https://github.com/SeaQL/sea-query/actions/runs/6733436762/job/18302124467?pr=478
clippy
https://github.com/SeaQL/sea-query/actions/runs/6733586499/job/18302635348?pr=718