String parameter should take generic Into<String>#594
Conversation
|
@billy1624 hello! I have pushed new commit. |
|
Hey @ikrivosheev, sorry for the delay. Had been starting a new proprietary project in the past two weeks loll. Now, I'm back :) |
ikrivosheev
left a comment
ikrivosheev
left a comment
There was a problem hiding this comment.
@billy1624 hello! LGTM!
tyt2y3
left a comment
tyt2y3
left a comment
There was a problem hiding this comment.
I think this has a real benefit - if given a String, we don't have to allocate a second time.
Yes, we only |
🎉 Released In 0.29.0 🎉Your participation is what makes us unique; your adoption is what drives us forward. |
🎉 Released In 0.29.1 🎉Thank you everyone for the contribution! |
3 participants
PR Info
Into<String>sea-orm#1439Breaking Changes
Changed the
&strparameter of the following methods to a genericT: Into<String>:Expr::cust():Expr::cust_with_values()Expr::cust_with_expr()Expr::cust_with_exprs()TableForeignKey::name()ForeignKeyCreateStatement::name()ForeignKeyDropStatement::name()TableIndex::name()IndexCreateStatement::name()IndexDropStatement::name()SqlWriterValues::new()ColumnType::custom()TableCreateStatement::engine()TableCreateStatement::collate()TableCreateStatement::character_set()TableRef::new()LikeExpr::str()Changed the
Stringparameter of the following methods to a genericColumnType::extra():LikeExpr::new()Changes
IntoLikeExprimplementations for all types implementedInto<String>Deprecates
LikeExpr::str(), please useLikeExpr::new()instead