Skip to content

ValueTuple::Many#564

Merged
ikrivosheev merged 2 commits intomasterfrom
value-tuple-many
Dec 22, 2022
Merged

ValueTuple::Many#564
ikrivosheev merged 2 commits intomasterfrom
value-tuple-many

Conversation

@billy1624
Copy link
Copy Markdown
Member

@billy1624 billy1624 commented Dec 21, 2022 •
edited
Loading

PR Info

New Features

  • Implement ValueTuple::Many for tuple with length up to 12

Breaking Changes

  • ValueTuple::Many is being added to replace all variants after ValueTuple::Three

@billy1624 billy1624 self-assigned this Dec 21, 2022
@billy1624 billy1624 marked this pull request as ready for review December 21, 2022 05:57
@tyt2y3
Copy link
Copy Markdown
Member

tyt2y3 commented Dec 21, 2022

NB:

    dbg!(std::mem::size_of::<Vec<i64>>());
    dbg!(std::mem::size_of::<(&i64, &i64, &i64)>());
[src/main.rs:2] std::mem::size_of::<Vec<i64>>() = 24
[src/main.rs:3] std::mem::size_of::<(&i64, &i64, &i64)>() = 24

@billy1624 billy1624 mentioned this pull request Dec 21, 2022
Closed
8 tasks
@billy1624
Copy link
Copy Markdown
Member Author

billy1624 commented Dec 21, 2022

Work as expected :D

ikrivosheev
ikrivosheev approved these changes Dec 21, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@ikrivosheev ikrivosheev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@billy1624 hello! Well, It makes sense... LGTM!

@ikrivosheev ikrivosheev merged commit e57ce82 into master Dec 22, 2022
@ikrivosheev ikrivosheev deleted the value-tuple-many branch December 22, 2022 09:22
@billy1624 billy1624 mentioned this pull request Feb 24, 2023
Merged
8 tasks
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 12, 2023

🎉 Released In 0.29.0 🎉

Your participation is what makes us unique; your adoption is what drives us forward.
Thank you all in the Rust community for making SeaQL what it is today. 🦀
You are also invited to shape it's future! Please star our repos, every ⭐ counts!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 20, 2023

🎉 Released In 0.29.1 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

@tyt2y3
Copy link
Copy Markdown
Member

tyt2y3 commented Jul 20, 2023

Sorry for the spam lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tyt2y3 tyt2y3 Awaiting requested review from tyt2y3

1 more reviewer

@ikrivosheev ikrivosheev ikrivosheev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@billy1624 billy1624

Labels

None yet

Projects

SeaQL Dev Tracker
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

large composite key table

3 participants

@billy1624 @tyt2y3 @ikrivosheev