Add ALTER TYPE statements for postgres#42
Conversation
|
Thank you for the PR, nicely done! If you intend to format an existing piece of code, please do so in a standalone |
Yep, that makes sense. Will avoid just running |
The test fails because of the extra space at the end of the assert. |
Fix typo Co-authored-by: Billy Chan <[email protected]>
|
I missed that! Thanks |
|
Looks good to me! Ready for merging? |
|
I intentionally ran cargo fmt on my branch to 'subtract out' those lines. |
For #38
This PR isn't ready. This is a draft so I can check if I am doing things right.
I have implemented ADD VALUE and RENAME TO so far. Before I start on OWNER, SET SCHEMA, ADD ATTRIBUTE, and the RESTRICT and CASCADE options - I wanted to some feedback to see if I'm on the right track with the builder and sql generation code.
If everything is fine I will continue with the PR and add documentation, if I'm doing anything wrong or there is a better way let me know!