Context:

Hey @anshul#9329, if you look at the rules of type affinity

For tables not declared as STRICT, the affinity of a column is determined by the declared type of the column, according to the following rules in the order shown:

1. If the declared type contains the string "INT" then it is assigned INTEGER affinity.

2. If the declared type of the column contains any of the strings "CHAR", "CLOB", or "TEXT" then that column has TEXT affinity. Notice that the type VARCHAR contains the string "CHAR" and is thus assigned TEXT affinity.

3. If the declared type for a column contains the string "BLOB" or if no type is specified then the column has affinity BLOB.

4. If the declared type for a column contains any of the strings "REAL", "FLOA", or "DOUB" then the column has REAL affinity.

5. Otherwise, the affinity is NUMERIC.

https://www.sqlite.org/datatype3.html#determination_of_column_affinity

The column defined with bool / boolean datatype are essentially treated as NUMERIC inside SQLite internal.

I prefer boolean over bool because of two reasons:

1. I mentioned above - Just to be aligned with the type affinity listed on SQLite docs: https://www.sqlite.org/datatype3.html#affinity_name_examples
2. We don't need to update any code inside sea-schema to parse the boolean column correctly. Because it's searching for boolean instead of bool: https://github.com/SeaQL/sea-schema/blob/1d377ed9ef33e3b0bd090c35b54c9c893e3076f2/src/sqlite/def/types.rs#L72

@billy1624 Thanks you for explaining. I'd totally missed this part of the table.

I've already renamed it to boolean in previous commits. What should be the next steps from here?

I've already renamed it to boolean in previous commits. What should be the next steps from here?

I think it's all good! After this PR is being merged, we should mention this bareaking change in the CHANGELOG. This PR should fix the original issue - #375 - once we bumped the SeaORM version on SeaSchema side.

@billy1624 should we make fix in sea-schema?

We don't need to update any code inside sea-schema to parse the boolean column correctly. Because it's searching for boolean instead of bool: https://github.com/SeaQL/sea-schema/blob/1d377ed9ef33e3b0bd090c35b54c9c893e3076f2/src/sqlite/def/types.rs#L72

According to my understanding, it will 'just work' with SeaSchema. Am I right?

According to my understanding, it will 'just work' with SeaSchema. Am I right?

Hey @tyt2y3, correct!