1.1.x: Add exists method to PaginatorTrait with tests#2843
Merged
Expurple merged 1 commit intoSeaQL:1.1.xfrom Dec 7, 2025
Merged
1.1.x: Add exists method to PaginatorTrait with tests#2843Expurple merged 1 commit intoSeaQL:1.1.xfrom
1.1.x: Add exists method to PaginatorTrait with tests#2843Expurple merged 1 commit intoSeaQL:1.1.xfrom
Conversation
* Add exists method to PaginatorTrait and corresponding tests * Refactor import order and simplify exists tests for better readability * Fix placed_at field to use ChronoDateTime for consistency in seed data * Remove performance comparison test for exists vs count methods from exists_tests * Refactor paginator query to use Expr::exists * Revert "Refactor paginator query to use Expr::exists" This reverts commit ef0521f. * Remove unnecessary database backend builder in paginator query
Member
Author
|
Clippy complaints come from the |
Huliiiiii
approved these changes
Dec 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase #2623 from
masterinto1.1.x.This is a nice backwards-compatible feature, I'd like to have it in
1.1.xand adopt in advance