Skip to content

Remove panics from select / update / delete#2627

Merged
tyt2y3 merged 6 commits intomasterfrom
db-err
Jun 15, 2025
Merged

Remove panics from select / update / delete#2627
tyt2y3 merged 6 commits intomasterfrom
db-err

Conversation

@tyt2y3
Copy link
Copy Markdown
Member

@tyt2y3 tyt2y3 commented Jun 15, 2025

This refactor removed two possible panics:

  1. arity mismatch (becomes DbErr::KeyArityMismatch)
  2. primary key not set (becomes DbErr::PrimaryKeyNotSet)

@tyt2y3 tyt2y3 requested review from Expurple and billy1624 June 15, 2025 15:14
@tyt2y3
Copy link
Copy Markdown
Member Author

tyt2y3 commented Jun 15, 2025

@Huliiiiii please take a look

},
/// (Primary) Key arity mismatch
#[error("Key arity mismatch: expected {expected}, got {got}")]
KeyArityMismatch {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "received" is a more appropriate and commonly used term.

@tyt2y3
Copy link
Copy Markdown
Member Author

tyt2y3 commented Jun 15, 2025

CI only fails because I have to release a new sea-query version

@tyt2y3 tyt2y3 merged commit 068b4bd into master Jun 15, 2025
13 of 33 checks passed
@tyt2y3 tyt2y3 deleted the db-err branch June 15, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants