Add exists method to PaginatorTrait with tests#2623
Add exists method to PaginatorTrait with tests#2623Expurple merged 8 commits intoSeaQL:masterfrom IgnisDa:exists
Conversation
|
Thank you! I'll review this a bit later. TODO for myself: also merge this in If you're ok with using your own unreleased fork of 1.1.x until 2.0.0 comes out, you can change the base of the PR to |
Can this be released as a patch 1.1.x release? I think it should be fine since it does not have any breaking changes. That way I can continue to use the crates.io version. |
|
Yeah, I assumed that you may want that. I'm not the one making (the decisions about) releases, but @tyt2y3 will probably do this |
|
@tyt2y3 Can you take a look at this please? Thanks! |
This reverts commit ef0521f.
Expurple
left a comment
Expurple
left a comment
There was a problem hiding this comment.
Thank you for the wait, I'll merge this myself
* Add exists method to PaginatorTrait and corresponding tests * Refactor import order and simplify exists tests for better readability * Fix placed_at field to use ChronoDateTime for consistency in seed data * Remove performance comparison test for exists vs count methods from exists_tests * Refactor paginator query to use Expr::exists * Revert "Refactor paginator query to use Expr::exists" This reverts commit ef0521f. * Remove unnecessary database backend builder in paginator query
Rebase #2623 from `master` into `1.1.x`. This is a nice backwards-compatible feature, I'd like to have it in `1.1.x` and adopt in advance
3 participants
Introduce an
existsmethod to thePaginatorTraitto efficiently check for record existence.Fixes #730.