This would require hotfixing latest release of sea-orm

thank you for submitting this quickly!

Let me release this quick

🎉 Released In 1.1.10 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

TransactionManager is a #[doc(hidden)] trait in an explicitly SemVer-exempt crate. This is a temporary fix at best.

I just noticed that it's actually exported from sqlx. This export will be deleted in 0.9.0 as it's not meant to be used directly.

I see what's going on: you're using your own RAII wrapper that's not compatible with sqlx::Transaction. I can see the motivation for that.

The issue is that TransactionManager is an implementation detail that needs to remain flexible so we can do things like add begin_with backwards-compatibly. That's why it's a #[doc(hidden)] trait.

We need to figure out a long-term solution here:

• You could use the trait from sqlx-core with a pinned version, but then you have to cut a release every time SQLx does.
• You could implement your own transaction handling and execute BEGIN, COMMIT and ROLLBACK statements directly. This offers SeaORM the most potential flexibility.
• We could design a non-RAII transaction begin/end API for SQLx. My main concern with this is that the RAII-based API should still be the preferred method for 99% of use-cases, so the design should make that obvious.

However, perhaps in general we need a better strategy for distinguishing whether SemVer applies only to usages of a trait, and not implementations. Then TransactionManager could just be a public trait. It should probably just be a supertrait of Connection, honestly.