Custom migrations table name#1475
Closed
sergeiivankov wants to merge 2 commits intoSeaQL:masterfrom
sergeiivankov:custom-migrations-table-name
Closed
Custom migrations table name#1475sergeiivankov wants to merge 2 commits intoSeaQL:masterfrom sergeiivankov:custom-migrations-table-name
sergeiivankov wants to merge 2 commits intoSeaQL:masterfrom
sergeiivankov:custom-migrations-table-name
Conversation
1 task
billy1624
reviewed
Feb 27, 2023
Member
billy1624
left a comment
billy1624
left a comment
There was a problem hiding this comment.
Hey @sergeiivankov, thanks for contributing!!
I think it's not ideal to override the migration table name with environment variable. It should be part of "migrator" and should be configured once and for all.
Inspired by your work, I just draft a PR, please check #1511 and let me know your thought :)
Contributor
Author
|
Hi @billy1624. I agree with you about my solution, I'm still not very good at navigating in sea-orm codebase to implement a more elegant solution. Your solution is great for me. I test it in my project, it work fine. Looking forward to being included in the next release. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Info
New Features
sea-orm-migrationcrate featurecustom-migrations-table-nameuser can set migrations table name toSEA_ORM_MIGRATIONS_TABLE_NAMEenvironment variable and crate will use it nameBreaking Changes
Changes