Generate entity for duplicated many-to-many paths by billy1624 · Pull Request #1435 · SeaQL/sea-orm

billy1624 · 2023-01-30T10:02:24Z

PR Info

Closes 0.10.6: still issues with conflicting implementations of trait #1333

Bug Fixes

The implementation of Related<R> with via and to methods will not be generated if there exists multiple paths via an intermediate table. Like in the schema defined below - Path 1. users <-> users_votes <-> bills, Path 2. users <-> users_saved_bills <-> bills

CREATE TABLE users
(
  id uuid  PRIMARY KEY  DEFAULT uuid_generate_v1mc(),
  email TEXT UNIQUE NOT NULL,
  ...
);

CREATE TABLE bills
(
  id uuid  PRIMARY KEY  DEFAULT uuid_generate_v1mc(),
  ...
);

CREATE TABLE users_votes
(
  user_id uuid REFERENCES users (id) ON UPDATE CASCADE ON DELETE CASCADE,
  bill_id uuid REFERENCES bills (id) ON UPDATE CASCADE ON DELETE CASCADE,
  vote boolean NOT NULL,
  CONSTRAINT users_bills_pkey PRIMARY KEY (user_id, bill_id)
);

CREATE TABLE users_saved_bills
(
  user_id uuid REFERENCES users (id) ON UPDATE CASCADE ON DELETE CASCADE,
  bill_id uuid REFERENCES bills (id) ON UPDATE CASCADE ON DELETE CASCADE,
  CONSTRAINT users_saved_bills_pkey PRIMARY KEY (user_id, bill_id)
);

Adapted from #1333 (comment)

tyt2y3 · 2023-01-30T10:57:44Z

.github/workflows/rust.yml

+      - uses: dtolnay/rust-toolchain@master
+        with:
+          toolchain: nightly
+          components: rustfmt
+      - run: cargo fmt --manifest-path ${{ matrix.path }} --all -- --check


what are these bits about though

Install nightly channel with rustfmt component. Then, run cargo +nightly fmt

Only night's fmt respect rustfmt.toml config file that's why.

billy1624 · 2023-01-30T11:42:17Z

This PR includes a written-entity to generated-entity test cases. Which works like this:

sea-orm is being added as dev-dependency on the codegen crate. All entity files under codegen/tests_cfg module are being compiled and checked.
The tests were performed at the end of transformer.rs. Using create_table_from_entity to generate SeaQuery create table statement from the SeaORM entity.
Then, the statement was passed to EntityTransformer and followed by EntityWriter::gen_compact_code_blocks.
Finally, assert the output from the writer againsts the file defined in codegen/tests_cfg

tyt2y3 · 2023-01-30T13:41:33Z

This is a very substantial change and seems to only fix a special case. Can we postpone this?

billy1624 · 2023-01-30T14:13:28Z

Okay, we can ship this with 0.11.1 and backport this to 0.10.x

Shall we?

tyt2y3 · 2023-01-31T06:06:21Z

No. I mean, to postpone it after 0.11

kev0960 · 2023-02-23T07:04:41Z

Just curious when this can be merged? It's the only blocker that we cannot upgrade to a newer version

tyt2y3 · 2023-02-23T13:24:53Z

Even if this gets merged now there will still be some time before the next release.
I can rebase the branch onto master, so you can install it and try it out locally.

* Optional Field SeaQL/sea-orm#1513 * .gitignore SeaQL/sea-orm#1334 * migration table custom name SeaQL/sea-orm#1511 * OR condition relation SeaQL/sea-orm#1433 * DerivePartialModel SeaQL/sea-orm#1597 * space for migration file naming SeaQL/sea-orm#1570 * composite key up to 12 SeaQL/sea-orm#1508 * seaography integration SeaQL/sea-orm#1599 * QuerySelect SimpleExpr SeaQL/sea-orm#1702 * sqlErr SeaQL/sea-orm#1707 * migration check SeaQL/sea-orm#1519 * postgres array SeaQL/sea-orm#1565 * param intoString SeaQL/sea-orm#1439 * **skipped** re-export SeaQL/sea-orm#1661 * ping SeaQL/sea-orm#1627 * on empty do nothing SeaQL/sea-orm#1708 * on conflict do nothing SeaQL/sea-orm#1712 * **skipped** upgrade versions * active enum fail safe SeaQL/sea-orm#1374 * relation generation check SeaQL/sea-orm#1435 * entity generation bug SeaQL/sea-schema#105 * **skipped** bug fix that does not require edits * EnumIter change SeaQL/sea-orm#1535 * completed and fixed a previous todo SeaQL/sea-orm#1570 * amended wordings and structures * Edit * Remove temp file --------- Co-authored-by: Billy Chan <[email protected]>

github-actions · 2023-08-02T17:12:34Z

🎉 Released In 0.12.1 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

billy1624 self-assigned this Jan 30, 2023

billy1624 force-pushed the gen-entity-duplicated-many-to-many-paths branch from fd58b72 to 372484d Compare January 30, 2023 10:09

billy1624 added this to the 0.11.x milestone Jan 30, 2023

billy1624 marked this pull request as ready for review January 30, 2023 10:39

billy1624 requested a review from tyt2y3 January 30, 2023 10:39

billy1624 mentioned this pull request Jan 30, 2023

0.10.6: still issues with conflicting implementations of trait #1333

Closed

tyt2y3 reviewed Jan 30, 2023

View reviewed changes

billy1624 removed this from the 0.11.x milestone Jan 30, 2023

billy1624 added 2 commits February 23, 2023 21:26

Generate entity for duplicated many-to-many paths

6e1d323

CI: run cargo fmt with nightly channel

fbe8968

tyt2y3 force-pushed the gen-entity-duplicated-many-to-many-paths branch from 5a174b8 to fbe8968 Compare February 23, 2023 13:27

tyt2y3 approved these changes Apr 11, 2023

View reviewed changes

billy1624 merged commit 2c08255 into master Apr 13, 2023

billy1624 deleted the gen-entity-duplicated-many-to-many-paths branch April 13, 2023 03:16

darkmmon added a commit to darkmmon/seaql.github.io that referenced this pull request Jul 12, 2023

relation generation check SeaQL/sea-orm#1435

980b896

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Generate entity for duplicated many-to-many paths#1435

Generate entity for duplicated many-to-many paths#1435
billy1624 merged 2 commits intomasterfrom
gen-entity-duplicated-many-to-many-paths

billy1624 commented Jan 30, 2023 •

edited

Loading

Uh oh!

tyt2y3 Jan 30, 2023

Uh oh!

billy1624 Jan 30, 2023 •

edited

Loading

Uh oh!

billy1624 Jan 30, 2023

Uh oh!

billy1624 commented Jan 30, 2023

Uh oh!

tyt2y3 commented Jan 30, 2023

Uh oh!

billy1624 commented Jan 30, 2023

Uh oh!

tyt2y3 commented Jan 31, 2023 •

edited

Loading

Uh oh!

kev0960 commented Feb 23, 2023

Uh oh!

tyt2y3 commented Feb 23, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Aug 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

billy1624 commented Jan 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Info

Bug Fixes

Uh oh!

tyt2y3 Jan 30, 2023

Choose a reason for hiding this comment

Uh oh!

billy1624 Jan 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

billy1624 Jan 30, 2023

Choose a reason for hiding this comment

Uh oh!

billy1624 commented Jan 30, 2023

Uh oh!

tyt2y3 commented Jan 30, 2023

Uh oh!

billy1624 commented Jan 30, 2023

Uh oh!

tyt2y3 commented Jan 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kev0960 commented Feb 23, 2023

Uh oh!

tyt2y3 commented Feb 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 2, 2023

🎉 Released In 0.12.1 🎉

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

billy1624 commented Jan 30, 2023 •

edited

Loading

billy1624 Jan 30, 2023 •

edited

Loading

tyt2y3 commented Jan 31, 2023 •

edited

Loading

tyt2y3 commented Feb 23, 2023 •

edited

Loading