Skip to content

Cont. feat: expose database connection to ActiveModelBehaviour's methods#1328

Merged
billy1624 merged 5 commits intomasterfrom
expose-db-to-active-model-behaviour
Jan 12, 2023
Merged

Cont. feat: expose database connection to ActiveModelBehaviour's methods#1328
billy1624 merged 5 commits intomasterfrom
expose-db-to-active-model-behaviour

Conversation

@billy1624
Copy link
Copy Markdown
Member

@billy1624 billy1624 commented Dec 22, 2022 •
edited
Loading

PR Info

New Features

  • before_save, after_save, before_delete and after_delete methods of ActiveModelBehavior receive db connection as the parameter

Breaking Changes

  • The ActiveModelBehaviour trait becomes async trait
    • For anyone who implement the ActiveModelBehaviour with default implementation (no-op). No code changes is required. 
      impl ActiveModelBehavior for ActiveModel {}
    • If you overridden the default implementation: 
      #[async_trait::async_trait]
impl ActiveModelBehavior for ActiveModel {
    async fn before_save<C>(self, db: &C, insert: bool) -> Result<Self, DbErr>
    where
        C: ConnectionTrait,
    {
        // ...
    }

    // ...
}

@billy1624 billy1624 self-assigned this Dec 22, 2022
@billy1624 billy1624 marked this pull request as ready for review December 23, 2022 13:10
@billy1624 billy1624 requested a review from tyt2y3 December 23, 2022 13:10
@billy1624
Copy link
Copy Markdown
Member Author

billy1624 commented Jan 4, 2023 •
edited
Loading

Hey @tyt2y3, we can include this in the upcoming release

tyt2y3
tyt2y3 requested changes Jan 11, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to have a test entity and some test cases for this

@billy1624
Copy link
Copy Markdown
Member Author

billy1624 commented Jan 11, 2023

Tests added

tyt2y3
tyt2y3 approved these changes Jan 12, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting

@tyt2y3
Copy link
Copy Markdown
Member

tyt2y3 commented Jan 12, 2023

I feel like we will have a lot of documentation to write

@billy1624
Copy link
Copy Markdown
Member Author

billy1624 commented Jan 12, 2023

I feel like we will have a lot of documentation to write

Yes, lots of breaking changes to be documented not to mention the new features lolll

@billy1624 billy1624 merged commit e2b796b into master Jan 12, 2023
@billy1624 billy1624 deleted the expose-db-to-active-model-behaviour branch January 12, 2023 09:22
denwong47 pushed a commit to denwong47/sea-orm that referenced this pull request Jan 20, 2023
@billy1624 @teenjuna @denwong47
Cont. feat: expose database connection to ActiveModelBehaviour's me…
5347dfb 
…thods (SeaQL#1328)

* feat: expose database connection to `ActiveModelBehaviour`'s methods (SeaQL#1145)

* Make ActiveModelTrait async

* Add tests

* refactoring

Co-authored-by: teenjuna <[email protected]>
billy1624 added a commit to SeaQL/seaql.github.io that referenced this pull request Feb 2, 2023
@billy1624
Methods of ActiveModelBehavior receive db connection as a parameter (…
ca2a9b6 
…SeaQL/sea-orm#1145, SeaQL/sea-orm#1328)
tyt2y3 added a commit to SeaQL/seaql.github.io that referenced this pull request Feb 3, 2023
@billy1624 @tyt2y3
SeaORM 0.11.x Docs - 1 (#87)
877caf8 
* Update 02-writing-migration.md

* Update SeaORM/docs/03-migration/02-writing-migration.md

* Support various UUID formats that are available in `uuid::fmt` module (SeaQL/sea-orm#1325)

* Casting columns as a different data type on select, insert and update (SeaQL/sea-orm#1304)

* Methods of `ActiveModelBehavior` receive db connection as a parameter (SeaQL/sea-orm#1145, SeaQL/sea-orm#1328)

* Added `execute_unprepared` method to `DatabaseConnection` and `DatabaseTransaction` (SeaQL/sea-orm#1327)

* Added `Select::into_tuple` to select rows as tuples (instead of defining a custom Model) (SeaQL/sea-orm#1311)

* Generate `#[serde(skip)]` for hidden columns (SeaQL/sea-orm#1171, SeaQL/sea-orm#1320)

* Generate entity with extra derives and attributes for model struct (SeaQL/sea-orm#1124, SeaQL/sea-orm#1321)

* Generate entity with extra derives and attributes for model struct (SeaQL/sea-orm#1124, SeaQL/sea-orm#1321)

* async_trait

* Migrations are now performed inside a transaction for Postgres (SeaQL/sea-orm#1379)

* `MockDatabase::append_exec_results()`, `MockDatabase::append_query_results()`, `MockDatabase::append_exec_errors()` and `MockDatabase::append_query_errors()` take any types implemented `IntoIterator` trait (SeaQL/sea-orm#1367)

* Cleanup the use of `vec!` macros

* Added `DatabaseConnection::close` (SeaQL/sea-orm#1236)

* Added `ActiveValue::reset` to convert `Unchanged` into `Set` (SeaQL/sea-orm#1177)

* Added `QueryTrait::apply_if` to optionally apply a filter (SeaQL/sea-orm#1415)

* Added the `sea-orm-internal` feature flag to expose some SQLx types (SeaQL/sea-orm#1297, SeaQL/sea-orm#1434)

* Add `QuerySelect::columns` method - select multiple columns (SeaQL/sea-orm#1264)

* Edit

* Update SeaORM/docs/02-install-and-config/02-connection.md

Co-authored-by: Chris Tsang <[email protected]>

* Update SeaORM/docs/05-basic-crud/03-insert.md

Co-authored-by: Chris Tsang <[email protected]>

* fmt

* Edit

---------

Co-authored-by: Chris Tsang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tyt2y3 tyt2y3 tyt2y3 approved these changes

Assignees

@billy1624 billy1624

Labels

None yet

Projects

SeaQL Dev Tracker
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

More context for ActiveModelBehaviour

3 participants

@billy1624 @tyt2y3 @teenjuna