chore(import): remove the OptiSigns provider - #3157
Merged
Merged
Conversation
OptiSigns' GraphQL gateway does not expose a downloadable file URL for uploaded assets (only a CDN-relative thumbnail key with no public base), and its web assets are internal *.optisigns.com apps, so an import returned nothing. Rather than ship a provider that imports nothing, remove it: provider module, registry entry, tests, and the website/wizard copy. The other providers (Yodeck, ScreenCloud, piSignage, Xibo) are unaffected. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
There was a problem hiding this comment.
Pull request overview
Removes the OptiSigns content-import provider from Anthias, including its implementation, tests, registry wiring, and user-facing documentation/copy, because the OptiSigns API does not expose usable downloadable URLs for uploaded assets.
Changes:
- Removed the OptiSigns provider module and its unit tests.
- Unregistered OptiSigns from the import provider registry.
- Updated docs and UI copy to no longer mention OptiSigns as a supported import source.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| website/content/docs/importing-content-from-other-platforms.md | Removes OptiSigns from supported-platform and CLI/provider documentation. |
| src/anthias_server/lib/integrations/registry.py | Removes OptiSigns provider import and registry entry. |
| src/anthias_server/lib/integrations/optisigns.py | Deletes the OptiSigns GraphQL import provider implementation. |
| src/anthias_server/lib/integrations/graphql.py | Updates GraphQL helper module docstring to reflect current provider usage. |
| src/anthias_server/lib/integrations/init.py | Updates integrations package docstring to remove OptiSigns references. |
| src/anthias_server/app/views.py | Updates import wizard view docstring to remove OptiSigns references. |
| src/anthias_server/app/templates/settings.html | Updates settings template comment to remove OptiSigns references. |
| src/anthias_server/api/tests/test_optisigns_import.py | Deletes OptiSigns provider unit tests. |
| src/anthias_server/api/tests/_graphql_helpers.py | Updates test helper docstring to remove OptiSigns mention. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Address Copilot: don't hard-code the provider list in the settings template, the import view docstring, or the package docstring, so the comments don't drift as providers change. Also fix an awkward line wrap. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the OptiSigns import provider.
Verification against the OptiSigns GraphQL gateway showed it cannot actually import content:
thumbnailkey, with no public base to build a URL from, andgetAssetDetailreturnsAPI_NOT_AVAILABLE). Every image/video would be skipped.*.optisigns.comapps (weather, social player), which are correctly filtered out.So an OptiSigns import returned nothing. Rather than ship a button that imports nothing, this removes the provider entirely: the provider module, its tests, the registry entry, and the website/wizard copy. Guessing an S3/CDN base was the only alternative and is not something we want to ship.
The other providers (Yodeck, ScreenCloud, piSignage, Xibo) are unaffected. If we later get an OptiSigns account on a plan that exposes file URLs, re-adding the provider is a new module plus one registry line.
Checklist
🤖 Generated with Claude Code