fix(import): correct ScreenCloud endpoints/download; broaden Yodeck files - #3152
Merged
Conversation
…iles
ScreenCloud:
- use the correct production endpoints (graphql.{eu,us}.screencloud.com)
- auto-detect the region by probing, so the operator need not specify it
- download the original from File.source (fileOutputs can be empty)
Yodeck:
- import transcoded videos via arguments.play_from_url
- fall back to the resized render (thumbnail_url) for uploaded images whose
original is not exposed by the API
- accept a bare token (the label prefix is optional)
Docs/UI:
- list every supported provider on the import doc (no external links)
- remove em-dashes from the import doc and the wizard help text
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR corrects and improves the “import from other platforms” providers (notably ScreenCloud and Yodeck) based on real-world testing, and updates docs/UI copy accordingly.
Changes:
- ScreenCloud: switch to the production regional GraphQL endpoints, auto-detect region by probing, and download from
File.source(with outputs as fallback). - Yodeck: broaden file URL resolution (including transcoded video URLs) and add an image thumbnail fallback when originals aren’t exposed; loosen token input expectations.
- Docs/UI: update supported-platforms copy and revise help text to remove em-dashes and reflect new credential guidance.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| website/content/docs/importing-content-from-other-platforms.md | Updates supported platform list and import behavior wording. |
| src/anthias_server/lib/integrations/yodeck.py | Expands URL resolution for Yodeck media downloads and updates token help text. |
| src/anthias_server/lib/integrations/screencloud.py | Fixes ScreenCloud endpoints, adds region autodetection + caching, and changes download URL selection. |
| src/anthias_server/lib/integrations/xibo.py | Minor token help text punctuation change. |
| src/anthias_server/lib/integrations/pisignage.py | Minor token help text punctuation change. |
| src/anthias_server/api/tests/test_yodeck_import.py | Updates/extends unit tests for new Yodeck file resolution behavior. |
| src/anthias_server/api/tests/test_screencloud_import.py | Adds tests/fixtures for ScreenCloud region detection and source download URL behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- ScreenCloud: an explicit region prefix now bypasses the auto-detection cache (was consulted first); cache is keyed by a one-way token hash so no credential is retained in memory - docs: reword so images/videos may be a non-original rendition and only items with no downloadable URL are flagged for manual re-upload - drop em-dashes from the provider docstring titles Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues Fixed
Corrections to the import providers found while testing them, plus doc/copy fixes.
Description
ScreenCloud
graphql.{eu,us}.screencloud.com); the previously-assumed*.next.schosts do not resolve.eu:/us:prefix still works as an override.File.source(thefileOutputsByFileIdrenditions can be empty).Yodeck
arguments.play_from_url.thumbnail_url) for uploaded images whose original is not exposed by the API, instead of skipping them.label:prefix is optional).Docs / UI
Providers reuse the shared ingest/http/graphql layer; tests updated and pass (ruff, mypy, pytest all green).
Checklist
🤖 Generated with Claude Code