feat(import): add piSignage (REST) provider to the import framework - #3148
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new piSignage (REST) import provider to Anthias’ existing import framework, wiring it into the provider registry and covering the behavior with unit tests (no network).
Changes:
- Implement
PiSignageProviderto authenticate viaPOST /session(JWT inx-access-token), list media viaGET /files, and import image/video assets via the shared ingest layer. - Register the provider in the integrations registry so it’s discoverable by the API/wizard/CLI.
- Add unit tests validating token parsing/login, listing classification, idempotent import behavior, and same-host download auth header attachment.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/anthias_server/lib/integrations/registry.py |
Registers PiSignageProvider in the import provider registry. |
src/anthias_server/lib/integrations/pisignage.py |
New REST provider implementation for piSignage (token parsing, login, listing, per-item import). |
src/anthias_server/api/tests/test_pisignage_import.py |
Unit tests for piSignage provider behavior with mocked session/network. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5 tasks
vpetersson
force-pushed
the
feat/import-content-optisign
branch
from
July 8, 2026 08:38
4d912c5 to
b99c866
Compare
- add a piSignage provider over the shared ImportProvider interface, reusing the ingest/http layer, wizard, and CLI - per-subdomain host + credential login (POST /session -> JWT, sent as x-access-token); operator token is "subdomain:email:password" - import image/video files from GET /files (skip audio); download from the same host with the token attached (scoped by ingest) - unit tests (no network) Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
- encode the filename as a single path segment (quote safe='') - normalise the media path to one leading slash before building the URL - coerce dbdata names to str so the files-list de-dupe is reliable Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
vpetersson
force-pushed
the
feat/import-content-pisignage
branch
from
July 8, 2026 08:42
445a8dd to
656d7a5
Compare
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues Fixed
Stacked on #3146 (OptiSigns). Fourth provider in the import series.
Description
ImportProviderinterface, wizard, and CLI as the others.POST /session) sent asx-access-token. Because both the subdomain and login are needed, the operator's token issubdomain:email:password.GET /files), imports image/video, skips audio. (Web-link assets aren't part of/files; noted as a follow-up.)ingestauth-scoping handles this (token attached only for the matching host).Follow-ups (flagged in
pisignage.py): confirm thepath→ download-URL mapping and whether the media host needs the token, against a live hosted account; web-link assets aren't imported.Checklist
🤖 Generated with Claude Code