feat(import): add OptiSigns (GraphQL) provider to the import framework - #3146
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds the OptiSigns (GraphQL) provider to Anthias’ import-provider framework, enabling content migration (images/videos/webpages) from OptiSigns accounts via the existing import wizard/API/CLI flow.
Changes:
- Registers a new
optisignsimport provider in the integrations registry. - Implements
OptiSignsProvider(GraphQL paging, classification, idempotent ingest via shared ingest/http layer). - Adds unit tests with mocked GraphQL + download behavior (no network).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/anthias_server/lib/integrations/registry.py |
Registers OptiSignsProvider so it is discoverable by API/UI/CLI. |
src/anthias_server/lib/integrations/optisigns.py |
Implements OptiSigns GraphQL listing + per-item import using shared ingest logic. |
src/anthias_server/api/tests/test_optisigns_import.py |
Adds mocked unit tests for token validation, classification, listing, and import behaviors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5 tasks
vpetersson
force-pushed
the
feat/import-content-screencloud
branch
2 times, most recently
from
July 8, 2026 08:32
c63fdcc to
b8f83fd
Compare
- add an OptiSigns provider over the shared ImportProvider interface, reusing the ingest/http layer, wizard, and CLI - one `assets` connection (no per-type/single-item query): classify by fileType (image/video) or a genuine external webLink (web pages) - filter non-portable content: skip apps/widgets, YouTube, and OptiSigns-hosted internal links; only import real downloadable files and external URLs - no auth on the CDN download; list errors surface as controlled 502s - unit tests (GraphQL mocked; no network) Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
vpetersson
changed the base branch from
feat/import-content-screencloud
to
master
July 8, 2026 08:38
- extract the GraphQL bearer/post/errors boilerplate into graphql.py and a shared duration helper into ingest, used by both GraphQL providers (removes the duplication Sonar flagged) plus shared test fakes - OptiSigns: drop the unused logger, compare on hostname (not netloc, which includes the port), and coerce the asset name to str before stripping Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
vpetersson
force-pushed
the
feat/import-content-optisign
branch
from
July 8, 2026 08:38
4d912c5 to
b99c866
Compare
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues Fixed
Stacked on #3145 (ScreenCloud). Third provider in the import series.
Description
graphql-gateway.optisigns.com): validates an API key (Bearer), pages the singleassetsconnection, and imports via the sameImportProviderinterface, wizard, and CLI. No per-type or single-item query exists, so a lookup is a filteredassets(query: {_id: …}).fileType; a genuine externalwebLink→ web page. Apps/widgets (appType), YouTube (youtubeType), and OptiSigns-hosted internal links are skipped-with-reason.Follow-ups (isolated, flagged in
optisigns.py): the exact downloadable original-file field (path/video_1080p— may be CDN-relative), theQueryAssetInput._idfilter shape, and thefileType/appTypevocabularies are undocumented — to confirm against a live OptiSigns account; unresolved originals are skipped rather than guessed.Checklist
🤖 Generated with Claude Code