fix(balena): add missing device types to unpin fleet map - #3051
Merged
Conversation
- Add anthias-pi3-64 and anthias-rockpi4 to FLEET_DEVICE_TYPE - Both fleets were in FLEETS but absent from the map, so they hit the "unknown device type" branch and the job exited 1 (errors=2) - Re-syncs the map with bin/balena_fleet_maintenance.py per the comment Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues Fixed
The scheduled Balena unpin devices workflow has been failing (exit 1). Example run: actions/runs/27294787701. The job ended with
errors=2:Description
bin/balena_unpin_devices.pyiterates every fleet inFLEETS(7 entries), but itsFLEET_DEVICE_TYPEmap only had 5 — the two newer fleets (anthias-pi3-64,anthias-rockpi4) were missing. Each fell into the! unknown device typebranch, counted as an error, and the run exited 1.The map had drifted from its sibling
bin/balena_fleet_maintenance.py(which already has all 7), despite the in-file comment saying they must stay in sync.Fix: add the two missing entries, copying the exact device-type slugs from
balena_fleet_maintenance.py:screenly_ose/anthias-pi3-64->raspberrypi3-64screenly_ose/anthias-rockpi4->rockpi-4b-rk3399Verified locally with a dry-run against the live balena API: both fleets now resolve their device type and target OS/supervisor, and the run finishes with
errors=0(exit 0).ruff checkandruff format --checkpass.Checklist
🤖 Generated with Claude Code