fix(server): surface the exception detail in GitHub update-check warnings - #3023
Merged
Conversation
…ings - A bare 'no data' hid the host/timeout info str(exc) carries — Sentry ANTHIAS-8 read 'ConnectionError fetching latest release from GitHub: no data', which said nothing actionable - Ported from #3014 (the rest of that PR shipped via #3019) Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
5 tasks
There was a problem hiding this comment.
Pull request overview
This PR improves the observability of Anthias’ GitHub “latest release” update-check by ensuring that warning logs include meaningful exception details when the request fails without an HTTP response (e.g., timeouts), making Sentry/event titles actionable.
Changes:
- Update
handle_github_error()to logstr(exc)(falling back to'no data') whenexc.responseisNone. - Add a regression test ensuring the no-response branch surfaces the exception detail in the warning log.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/anthias_server/lib/github.py |
Improves warning log content for no-response GitHub request failures by surfacing exception detail. |
tests/test_github.py |
Adds a focused unit test to assert the warning log includes the exception message for no-response failures. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues Fixed
Follow-up to ANTHIAS-8 / #3019; ports the one improvement from #3014 that #3019 didn't carry.
Description
handle_github_error's no-response branch logged a literalno data, which is what made the original Sentry title ("ConnectionError fetching latest release from GitHub: no data") unactionable. Usestr(exc) or 'no data'so the warning carries the host/timeout detail.The rest of #3014 (the warning-level downgrade) already shipped in #3019, so #3014 can be closed.
Checklist
🤖 Generated with Claude Code