4.0.x Fixes crash with ScatterPlots containing a single point#949
Merged
swharden merged 2 commits intoScottPlot:4.0-stablefrom Apr 10, 2021
Merged
4.0.x Fixes crash with ScatterPlots containing a single point#949swharden merged 2 commits intoScottPlot:4.0-stablefrom
swharden merged 2 commits intoScottPlot:4.0-stablefrom
Conversation
Member
Author
|
I ran |
Contributor
The reason is that the 4.0 branch does not contain this fix 08812ef. |
Member
|
Hi @bclehmann, thanks for this fix!
I'm happy to continue to maintain 4.0 to make small changes that fix bugs (though I don't intend to add new features there). My plan is to merge this is now but not release a new 4.0 package yet. I'll get 4.1 released, then add a pop-up NuGet readme to the 4.0 branch informing people about 4.1, directing people to the FAQ/cookbook, etc., and then upload that package |
48 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Contributors:
please review CONTRIBUTING.md
Purpose:
#948
I don't know how you feel about backporting fixes to 4.0.x right now, I guess it depends on how soon you plan to release 4.1. In my opinion, even if you released 4.1.0 tomorrow trivial fixes like this should continue for at least a little while because 4.0 -> 4.1 does entail a sizeable number of breaking changes, even if many of them can be alleviated by search and replace. This is made easier by the fact that 4.0.48 seems pretty stable, so it shouldn't be too difficult to maintain.
The only difficulty is that 4.0.x and 4.1.x have different directory structures and the solution file has a different name. Which means you have to close Visual Studio and normally run
git clean -dfand sometimesgit reset --hardwhen switching between the branches. I think this is supposed to be what git worktrees are for but I've never used them. Regardless, more an annoyance than anything else.New Functionality:
N/A