Skip to content

Minor houskeeping on ScottPlot.Tools#935

Merged
swharden merged 2 commits intoScottPlot:masterfrom
bclehmann:cleanup-tools
Apr 10, 2021
Merged

Minor houskeeping on ScottPlot.Tools#935
swharden merged 2 commits intoScottPlot:masterfrom
bclehmann:cleanup-tools

Conversation

@bclehmann
Copy link
Member

New Contributors:
please review CONTRIBUTING.md

Purpose:

  • Refactors XYToIntensities and adds comments
  • Adds support for different decimal points in ToDifferentBase
    • You can get the decimal separator of a locale with CultureInfo.NumberFormat.NumberDecimalSeparator
    • However it looks like axes with non-decimal radixes has been removed, so this may be immaterial unless you want to move to reimplement it

New Functionality:
N/A

@swharden
Copy link
Member

I'm going to go ahead and merge this in to keep the ball rolling, but eventually:

@swharden swharden merged commit 5ca194f into ScottPlot:master Apr 10, 2021
@swharden swharden mentioned this pull request Apr 10, 2021
48 tasks
@swharden
Copy link
Member

axes with non-decimal radixes has been removed

Thanks for noting this! I dropped a lot of functionality that added complexity to the tick system in an effort to make it easier to refactor a few months ago. An overhaul of the tick module is still a medium-term goal (#716), and I intend to add support for non-decimal radixes back in and add support other advanced features at that time.

@swharden swharden mentioned this pull request May 17, 2021
82 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants