Conversation
|
I've documented most of it but I'm going to come back to a few bits that I missed. Note that it fails test intentionally because I added a test to ensure that all I'm not entirely sure what this function does: ScottPlot/src/ScottPlot/DataGen.cs Line 63 in 1aa56bd A quick google says it's some audio thingy but I elected not to document something I'm not sure about. It may also be a good idea to document the |
|
Aside from documenting the class, I have a few questions about some methods:
|
|
Hi @bclehmann, Thanks so much for this PR! It's shaping up really well. I'll add a couple comments for you to consider along the way:
|
The answer to all 3 questions, perhaps unsatisfyingly, is that there is no good reason/justification for those decisions. I suspect they originated in a test or a WinForms demo application and were copy/pasted into the If possible, I'd like to take as many hints from the numpy API as possible. They have most of these functions already, and the documentation is pretty good. We can probably recycle a lot of their design and documentation. E.g., https://numpy.org/doc/stable/reference/random/generated/numpy.random.normal.html |
|
I've finished most of it, here's what I have left:
In terms of what I'd like if we were to make a new class, here's my thinking:
A lot of these functions have overloads that can be gotten rid of, either through default parameters or through just not having a reason to exist as a separate overload. Additionally, the consistency could be improved, some random functions take a seed, and some take a |
|
Support for lots of random distributions could probably be done by having each distribution have a If you wanted to get extra fancy, you could find a way to extend this to things like |
|
I think double[] ys = ScottPlot.DataGen.SinSweep(pointCount: 5000, density: 20);Related, I've used this to study some biological properties of neurons: https://github.com/swharden/pyABF/blob/master/docs/advanced/creating-waveforms
Altogether the sweeping sine wave is a pretty niche need and can probably be omitted from future data generation modules |
When it comes time to redesign the Specifically, |


New Contributors:
please review CONTRIBUTING.md
Purpose:
#902
New Functionality:
N/A