Implemented separable gaussian blur for improved performance.#667
Merged
swharden merged 1 commit intoScottPlot:masterfrom Dec 21, 2020
Merged
Implemented separable gaussian blur for improved performance.#667swharden merged 1 commit intoScottPlot:masterfrom
swharden merged 1 commit intoScottPlot:masterfrom
Conversation
In ScottPlot.Tools.XYToIntensities
Member
Author
|
This does not address the concerns raised in #666, although this PR could be expanded to do so. |
48 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In ScottPlot.Tools.XYToIntensities
New Contributors:
please review CONTRIBUTING.md
Purpose:
Improved performance for
ScottPlot.Tools.XYToIntensitieswhen using gaussian intensity mode.The gaussian blur is separable, instead of using an n x n matrix as the kernel one can use a 1 x n matrix followed by an n x 1 matrix. This gives O(n) complexity instead of O(n^2).
Note that the previous code did not explicitly use a blur filter, but instead applied the gaussian after adding each coordinate. This is still O(n^2).
This code also precomputes the kernel, which ought to bring a performance boost of its own.
New Functionality:
N/A