Conversation
|
Hi @swharden, I decided to try to do it through The main meaning of such an early PR, a lot of small questions that have arisen and will arise, I will write them here. Access to Here is some questions:
|
|
Hi @StendProg, this is very interesting work! Here are my thoughts based on the modified files and your comments. Nullable ColorsPresently these colors are nullable
I agree! Nullable value types can be confusing and introduce errors, and it would be nice to eliminate them if possible. I notice that the null logic for Exposed System.Drawing Objects
Currently pens are created in the constructor and stored at the class level as public fields: I think the best way to proceed is to ensure that CapitalizationWhen I first created ScottPlot I made all public fields lowercase because that is the naming convention of Python (the language I was most familiar with at the time). I now recognize the C# Capitalization Conventions says public fields should be capitalized. I can see you've capitalized public fields this with this PR. This change will modify a large number of files (especially if it is done for every plottable), so it may be a good idea to keep existing public fields with the same name for now (simplifying this PR), and we can make all fields capitalized in 4.1 at the same time we make lots of other breaking changes. Thank you @StendProg for your excellent work on this! |
|
This test not culture invariant and always fail for me on local computer. Expected result is |
|
|
This comment has been minimized.
This comment has been minimized.
966fce1 to
61e1d21
Compare
|
What parameters should the new signal constructor contain?
I chose the second option, everything works fine. |
…SignalXY, PlottableSignalXYConst.
It runs anytime on xs set compare to previous constructor only. Remove this check and fix tests is an option...
Remove old constructor.
also stopped storing pen arrays at the class level
|
Hi @StendProg, thank you for your hard work on this! I know from reviewing this PR that the new rendering system took a lot of time and thought to implement. There are some improvements I still wish to make, but I'm going to merge this in now so I can improve the validation system for all plottables at the same time. I'll discuss these topics in #578 |
Work In Progress.
Purpose:
Part of #578
New Functionality:
In progress.