WinUI: Add keyboard modifier detection (#4967)#4970
Merged
swharden merged 4 commits intoScottPlot:mainfrom Jul 29, 2025
Merged
Conversation
- Supports Ctrl, Shift, Alt, and Windows key detection from PointerEventArgs - Enables modifier key combinations in WinUI mouse interactions - Foundation for implementing Ctrl+Click, Shift+Drag functionality
Member
|
Thanks @diluculo! I don't spend a lot of time working with WinUI so I really appreciate input from developers like you who are much more familiar with the platform. I'm going to merge this now and I intend to publish a new set of NuGet packages within the next few weeks. Thanks again! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
UpdateKeyStateFromModifiershelper to detect Ctrl/Shift/Alt states from mouse events, enabling enhanced interactions like Ctrl+MouseWheel zoom.Also upgrades Windows App SDK to 1.7 and lowers target framework to net8.0-windows10.0.19041.0 due to v1.5 runtime issues in my environment (can be reverted if needed).
Fixes #4967
Additional Notes
For future
KeyDown/KeyUpevent handling fromSKXamlCanvasinWinUIPlot.cs, theCreateRenderTarget()method would need focus-related properties:This PR focuses on mouse-based modifier detection using
PointerRoutedEventArgs, which doesn't require focus.