FontStyler.Set: prevent premature disposal of SKTypeface#4958
Merged
swharden merged 3 commits intoScottPlot:mainfrom Jul 29, 2025
Merged
FontStyler.Set: prevent premature disposal of SKTypeface#4958swharden merged 3 commits intoScottPlot:mainfrom
swharden merged 3 commits intoScottPlot:mainfrom
Conversation
swharden
changed the title
Member
|
Thanks @sproott! This was a very confusing issue to track down, but I appreciate your help figuring it out and recommending this fix! I'm merging now, and I intend to release an updated NuGet package within the next few weeks. Thanks again! 🚀 |
swharden
added a commit
that referenced
this pull request
Aug 17, 2025
re-implements #4958 Co-authored-by: sproott <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes the issue described in #4910.
The
SKTypefaceobject obtained inFontStyler.Set(string fontName)was being disposed of while still being referenced from the internal cache of theFontsclass. By removing theusingkeyword, the unwanted disposal doesn't happen anymore.