Merged
Conversation
bclehmann
reviewed
Mar 3, 2025
Member
bclehmann
left a comment
There was a problem hiding this comment.
This looks good, I just have a couple of thoughts but a lot of them are minor and nitpicky
6432b9a to
5dd69bb
Compare
Member
|
Hi @CoderPM2011, thanks so much for this PR! I'm going to put some time into this now and will refactor it a bit, merge, and publish a new package today 🚀 I suspect I'll disentangle the inheritance structure, and also address Ben's concern about text customization along the way |
Member
Member
Member
publish a new package |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



resolve #4751.
I inherited class of
TextPlot and added the graphic rendering part ofTooltip.Since
RenderTooltipShape()is designed to beprotected virtual, users can implement custom subclasses if they have different ideas about the current design. 😉The current design requires the tail target coordinates to be specified and will automatically rotate in the target direction.
Customizable tooltip tail width percentage.
The actual width of the tail is the lesser of the length or width of the tooltip body.
The image below shows the actual shape of the tail profile.
demo image
demo code