Fix ternary coordinate validation in TriangularAxis#4798
Merged
swharden merged 11 commits intoScottPlot:mainfrom Feb 16, 2025
manaruto:main
Merged
Fix ternary coordinate validation in TriangularAxis#4798swharden merged 11 commits intoScottPlot:mainfrom manaruto:main
swharden merged 11 commits intoScottPlot:mainfrom
manaruto:main
Conversation
This PR fixes an issue with the `GetCoordinates` method in `TriangularAxis`. The original method incorrectly enforced `leftFraction + rightFraction = 1`, which violates ternary plot rules.
Fixed whitespace formatting in TriangularAxis.cs
Contributor
Author
|
The Can someone verify if the I i tried to fix that file but with no success. |
Member
|
Hi @manaruto, thanks for this PR!
I'll take a look now... |
Member
|
There's some weirdness about the line endings not getting corrected on git changes in the autoformatter workflow... I'll ignore it for now, merge this, and ensure it's working in subsequent PRs. Sorry for the extra noise 😅 This is a great improvement - thanks for this PR! It will be in the next release 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the
GetCoordinatesmethod inTriangularAxis. The original method incorrectly enforcedleftFraction + rightFraction = 1, which violates ternary plot rules.bottomFraction + leftFraction + rightFraction = 1as required for valid ternary plots.#4797