WinUI: fix conditional compilation for .NET 8#4374
Merged
swharden merged 2 commits intoScottPlot:mainfrom Oct 22, 2024
vilgotf:winui-net8
Merged
WinUI: fix conditional compilation for .NET 8#4374swharden merged 2 commits intoScottPlot:mainfrom vilgotf:winui-net8
swharden merged 2 commits intoScottPlot:mainfrom
vilgotf:winui-net8
Conversation
.NET 8 was recently added as a target framework which exposed this condition as too limited as it is only true for .NET 6. Since WinUI 3 requires .NET 6 and Windows 10 1809, this condition can be wholly removed; dependents will fail the WASDK conditions regardless.
Member
|
Thanks @vilgotf! I'll publish a new package on Nuget within the next few days and I'm excited that this will be in it 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.NET 8 was recently added as a target framework which exposed this condition as too limited as it is only true for .NET 6.
Since WinUI 3 requires .NET 6 and Windows 10 1809, this condition can be wholly removed; dependents will fail the WASDK conditions regardless.
Closes #4288